[PR #961/898ade59 backport][stable-4] Unit test cleanup #962
Conversation
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Unit test cleanup SUMMARY Speaking to @mattclay, pytest based unit tests are generally considered preferred over unittest based unit tests. For the sake of having "good" examples in amazon.aws, migrates unittest based tests over to pytest Additionally: Moves tests about to reflect module_utils Cleans up the boto3/botocore test skipping uses "pytest.raises" rather than try/except blocks Cleans up unused variables Cleans up unused imports fixes s3_object unit test (was trying to import from the old location, redirects don't handle this) ISSUE TYPE Feature Pull Request COMPONENT NAME tests/units ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> (cherry picked from commit 898ade5)
|
@patchback[bot] This PR contains |
ansibullbot
added
feature
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 19s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 19s |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-4/898ade59bfa6ca5692303f8bc20eefde0734ba94/pr-961
branch
…collections#962) wafv2_web_acl: prevent exception when element is not a dict SUMMARY the geo_match_statement statement paremeter country_codes is a list and will fail the current implementation File "/tmp/ansible_community.aws.wafv2_web_acl_payload_8xvwtxvw/ansible_community.aws.wafv2_web_acl_payload.zip/ansible_collections/community/aws/plugins/module_utils/wafv2.py", line 52, in wafv2_snake_dict_to_camel_dict AttributeError: 'str' object has no attribute 'keys' rules: - name: block-germany priority: 0 action: block: {} visibility_config: sampled_requests_enabled: yes cloud_watch_metrics_enabled: yes metric_name: block-germany statement: geo_match_statement: country_codes: - DE ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/module_utils/wafv2.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
This is a backport of PR #961 as merged into main (898ade5).
SUMMARY
Speaking to mattclay,
pytestbased unit tests are generally considered preferred overunittestbased unit tests. For the sake of having "good" examples in amazon.aws, migrates unittest based tests over to pytestAdditionally:
ISSUE TYPE
COMPONENT NAME
tests/units
ADDITIONAL INFORMATION